Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(feature-flag): add ALERTS_ATTACH_REPORTS feature flag #1042

Merged

Conversation

lilykuang
Copy link
Member

🏆 Enhancements
This pr adds ALERTS_ATTACH_REPORTS feature flag from apache/superset to conditionally enable features in superset-ui.

@lilykuang lilykuang requested a review from a team as a code owner April 6, 2021 18:37
@vercel
Copy link

vercel bot commented Apr 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/4dhxEYiZfzWwXvw3aAhK8Lyhj2NB
✅ Preview: https://superset-ui-git-fork-preset-io-lily-add-alerts-attach-c4d497.vercel.app

@lilykuang lilykuang changed the title add alert/report ALERTS_ATTACH_REPORTS feature flag feat(alert/report): add ALERTS_ATTACH_REPORTS feature flag Apr 6, 2021
@lilykuang lilykuang changed the title feat(alert/report): add ALERTS_ATTACH_REPORTS feature flag feat(feature-flag): add ALERTS_ATTACH_REPORTS feature flag Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #1042 (ee2fb27) into master (68a5e00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1042   +/-   ##
=======================================
  Coverage   27.65%   27.65%           
=======================================
  Files         428      428           
  Lines        8797     8797           
  Branches     1335     1335           
=======================================
  Hits         2433     2433           
  Misses       6183     6183           
  Partials      181      181           
Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a5e00...ee2fb27. Read the comment docs.

@lilykuang lilykuang merged commit 84cc5e7 into apache-superset:master Apr 6, 2021
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
…perset#1042)

* add alert/report ALERTS_ATTACH_REPORTS feature flag

* fix lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants